ci: use stable toolchain for compiling xtask #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-fatfs-ci
branch
2 times, most recently
from
0df2fbf to
c94a63b
Compare
The xtask tests don't need to use the nightly toolchain or have any features set. Partially fixes #397
The nightly rust compiler is currently unable to compile the version of fatfs we are using in xtask. Rust bug: rust-lang/rust#95538. But we don't need to use nightly to compile xtask. In the CI, install both stable and nightly toolchains. The stable toolchain will be used by default, and xtask already knows to insert `+nightly` when building uefi-rs, so there's no need to set `override: true` for the nightly toolchain anymore. Fixes #397
nicholasbishop
force-pushed
the
bishop-fix-fatfs-ci
branch
from
c94a63b to
32800a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly rust compiler is currently unable to compile the version of
fatfs we are using in xtask. Rust bug:
rust-lang/rust#95538. But we don't need to use
nightly to compile xtask. In the CI, install both stable and nightly
toolchains. The stable toolchain will be used by default, and xtask
already knows to insert
+nightlywhen building uefi-rs, so there's noneed to set
override: truefor the nightly toolchain anymore.Fixes #397